Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests in test_pytorch_onnx_onnxruntime #37868

Closed
wants to merge 4 commits into from
Closed

Enable tests in test_pytorch_onnx_onnxruntime #37868

wants to merge 4 commits into from

Conversation

KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented May 5, 2020 •
edited

Enable tests in tests/onnx/test_pytorch_onnx_onnxruntime.py for:

  • Einsum
  • SoftmaxCrossEntropy
  • NLLLoss
  • normalize
  • pixel_shuffle
  • test_interpolate_no_shape
  • test_arange_dynamic
  • test_slice_neg_large_negone
    since there is a support in ORT for these operators.

@KsenijaS KsenijaS changed the title Enable tests for Einsum, SoftmaxCrossEntropy, NLLLoss Enable tests for Einsum, SoftmaxCrossEntropy and NLLLoss May 5, 2020
@KsenijaS
Copy link
Contributor Author

KsenijaS commented May 5, 2020

@neginraoof @lara-hdr please review

@dr-ci
Copy link

dr-ci bot commented May 5, 2020 •
edited

💊 CI failures summary and remediations

As of commit 2d3276f (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 5 times.

@mruberry mruberry requested a review from houseroad May 5, 2020 22:11
@mruberry mruberry added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 5, 2020
houseroad
houseroad requested changes May 6, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests failed

facebook-github-bot
facebook-github-bot reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@KsenijaS
Copy link
Contributor Author

KsenijaS commented May 6, 2020

The tests failed

PR #37239 updates ort nightly version, after it's merged I will rebase my branch and the tests should pass.

@neginraoof
Copy link
Contributor

@KsenijaS ORT is now updated in master. Please rebase this.
Thanks.

lara-hdr
lara-hdr approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@lara-hdr lara-hdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@KsenijaS
Copy link
Contributor Author

@houseroad CI is green! LGTM.

@KsenijaS KsenijaS changed the title Enable tests for Einsum, SoftmaxCrossEntropy and NLLLoss Enable tests in test_pytorch_onnx_onnxruntime May 15, 2020
houseroad
houseroad approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

facebook-github-bot
facebook-github-bot reviewed May 17, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 711f258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@lara-hdr lara-hdr lara-hdr approved these changes

@houseroad houseroad houseroad approved these changes

Assignees
No one assigned
Labels
Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@KsenijaS @neginraoof @facebook-github-bot @lara-hdr @houseroad @pytorchbot @mruberry