[ONNX] Support clamp_min and clamp_max #37872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruberry
added
module: onnx
neginraoof
reviewed
May 6, 2020
| @@ -1515,6 +1515,15 @@ def forward(self, x, k): | |||
| k = torch.tensor(3) | |||
| self.run_test(MyModuleDynamic(), [x, k]) | |||
|
|
|||
| @skipIfUnsupportedOpsetVersion([7, 12]) | |||
There was a problem hiding this comment.
Why is opset 12 skipped?
There was a problem hiding this comment.
I guess we can enable this after ORT version is updated?
neginraoof
approved these changes
May 6, 2020
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad merged this pull request in 7be9796. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clamp_min is used in
torch.nn.functional.normalize. Update symbolic_opset11 to support with updated clip in onnx opset 11.