Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Constant Folding Tests #38751

Closed
wants to merge 3 commits into from
Closed

Enable Constant Folding Tests #38751

wants to merge 3 commits into from

Conversation

KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented May 20, 2020 •
edited

Enable tests for constant folding since constant folding is enabled for opset 12

@KsenijaS KsenijaS changed the title Enable Constant folding tests Enable Constant Folding Tests May 20, 2020
@KsenijaS
Copy link
Contributor Author

please review @neginraoof

@dr-ci
Copy link

dr-ci bot commented May 20, 2020 •
edited

💊 CI failures summary and remediations

As of commit 460f37b (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 6 times.

@KsenijaS
Copy link
Contributor Author

@houseroad Failure on CI is not introduced by this PR. Please review

neginraoof
neginraoof approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ailzhang ailzhang requested a review from houseroad May 21, 2020 16:40
@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 21, 2020
@KsenijaS
Copy link
Contributor Author

@houseroad for review. Thanks!

@ezyang ezyang removed the request for review from houseroad May 26, 2020 20:03
@ezyang ezyang removed the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 26, 2020
facebook-github-bot
facebook-github-bot reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 26, 2020
@ezyang ezyang requested a review from houseroad May 26, 2020 20:17
@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 0edf063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@neginraoof neginraoof neginraoof approved these changes

@houseroad houseroad Awaiting requested review from houseroad

Assignees
No one assigned
Labels
Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@KsenijaS @facebook-github-bot @neginraoof @ezyang @ailzhang @pytorchbot @mruberry