Fix KeypointRCNN test #39589
Fix KeypointRCNN test #39589
Conversation
|
@neginraoof please review |
💊 CI failures summary and remediationsAs of commit 5b4916c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 19 times. |
|
@houseroad please review. Thanks! |
|
there is a mismatch between PyTorch and ORT, currently investigating the issue |
ngimel
added
the
triaged
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad bug was fixed on the torchvision side: pytorch/vision#2312, test is passing on my local machine. |
|
Do we need to merge the pr in torchvision first? cc: @fmassa |
|
@houseroad pr is already merged in torchvision |
|
So will the test pass if we retrigger it? |
|
@houseroad I have already retrigger it this morning, it is still failing on the CI but it passes locally. |
|
@houseroad CI is green. Can we merge this? |
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad merged this pull request in da8cd82. |
Summary: Since Argmax is updated in ONNX Runtime we can enable testing for all output, including keypoints_scores. Pull Request resolved: pytorch#39589 Reviewed By: hl475 Differential Revision: D21992264 Pulled By: houseroad fbshipit-source-id: a390b4628d2ac290902b9e651c69d47db9be540f
Since Argmax is updated in ONNX Runtime we can enable testing for all output, including keypoints_scores.