Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Update pytorch/onnx docs for new export API args #39802

Closed
wants to merge 10 commits into from
Closed

[ONNX] Update pytorch/onnx docs for new export API args #39802

wants to merge 10 commits into from

Conversation

neginraoof
Copy link
Contributor

Update pytorch/onnx docs for new export API args:
Use external data format and Training args.

@dr-ci
Copy link

dr-ci bot commented Jun 10, 2020 •
edited

💊 CI failures summary and remediations

As of commit 8b89a34 (more details on the Dr. CI page):

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py 
Auto-merging .circleci/cimodel/data/pytorch_build_data.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/caffe2_build_definitions.py 
Auto-merging .circleci/cimodel/data/caffe2_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_definitions.py 
Auto-merging .circleci/cimodel/data/binary_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py 
Auto-merging .circleci/cimodel/data/binary_build_data.py 
Automatic merge failed; fix conflicts and then commit the result.

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py 
Auto-merging .circleci/cimodel/data/pytorch_build_data.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/caffe2_build_definitions.py 
Auto-merging .circleci/cimodel/data/caffe2_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_definitions.py 
Auto-merging .circleci/cimodel/data/binary_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py 
Auto-merging .circleci/cimodel/data/binary_build_data.py 
Automatic merge failed; fix conflicts and then commit the result.

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_bazel_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

Jun 16 18:31:26 TIMEOUT: //:optim_test (Summary) 
Jun 16 18:30:44 [ RUN      ] PackedSequenceTest.To 
Jun 16 18:30:44 [       OK ] PackedSequenceTest.To (3 ms) 
Jun 16 18:30:44 [----------] 3 tests from PackedSequenceTest (26 ms total) 
Jun 16 18:30:44  
Jun 16 18:30:44 [----------] Global test environment tear-down 
Jun 16 18:30:44 [==========] 9 tests from 2 test suites ran. (3593 ms total) 
Jun 16 18:30:44 [  PASSED  ] 9 tests. 
Jun 16 18:30:44 ================================================================================ 
Jun 16 18:30:52 [2,525 / 2,526] 24 / 25 tests, 1 failed; Testing //:optim_test; 280s processwrapper-sandbox 
Jun 16 18:31:26  
Jun 16 18:31:26 TIMEOUT: //:optim_test (Summary) 
Jun 16 18:31:26       /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/execroot/pytorch/bazel-out/k8-fastbuild/testlogs/optim_test/test.log 
Jun 16 18:31:26 INFO: From Testing //:optim_test: 
Jun 16 18:31:26 ==================== Test output for //:optim_test: 
Jun 16 18:31:26 Running main() from gmock_main.cc 
Jun 16 18:31:26 Note: Google Test filter = -*CUDA 
Jun 16 18:31:26 [==========] Running 28 tests from 1 test suite. 
Jun 16 18:31:26 [----------] Global test environment set-up. 
Jun 16 18:31:26 [----------] 28 tests from OptimTest 
Jun 16 18:31:26 [ RUN      ] OptimTest.OptimizerAccessors 
Jun 16 18:31:26 [       OK ] OptimTest.OptimizerAccessors (3 ms)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 10 times.

BowenBao
BowenBao reviewed Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

docs/source/onnx.rst Outdated Show resolved Hide resolved
docs/source/onnx.rst Outdated Show resolved Hide resolved
neginraoof and others added 4 commits June 16, 2020 10:13
@neginraoof @BowenBao
Update docs/source/onnx.rst
d9da3a3 
Co-authored-by: Bowen Bao <semisqg@gmail.com>
@neginraoof @BowenBao
Update docs/source/onnx.rst
b2061d0 
Co-authored-by: Bowen Bao <semisqg@gmail.com>
@neginraoof
Update onnx.rst
8c1ac35
@neginraoof
Update onnx.rst
8b89a34
facebook-github-bot
facebook-github-bot reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 73a156e.

xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
@neginraoof @xwang233
[ONNX] Update pytorch/onnx docs for new export API args (pytorch#39802)
d4da4de 
Summary:
Update pytorch/onnx docs for new export API args:
Use external data format and Training args.
Pull Request resolved: pytorch#39802

Reviewed By: hl475

Differential Revision: D22139664

Pulled By: houseroad

fbshipit-source-id: 7d6dcf75129cb88987f8c37b7d9d48ca594c0f38
@jcwchen jcwchen mentioned this pull request Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@BowenBao BowenBao BowenBao approved these changes

@houseroad houseroad houseroad approved these changes

Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neginraoof @facebook-github-bot @BowenBao @houseroad @mruberry