Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1019 initial draft for accessible name using caption role #1020

Closed
wants to merge 20 commits into from

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Jul 22, 2019

Proposed definition of accessible name from caption

Proposed list of roles that support name from caption

proposed changes to figure definition

proposed changes to grid definition

proposed changes to table definition


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jan 20, 2021, 11:00 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL


😭  Sorry, there was an error generating the HTML. Please report this issue!
Specification: https://rawcdn.githack.com/w3c/aria/692220c7656b3de75d3b156d18329a70609dd636/index.html?isPreview=true&publishDate=2021-01-20
ReSpec version: 25.6.0
File a bug: https://github.com/w3c/respec/
Error: Error: Evaluation failed: Timeout: document.respec.ready didn't resolve in 0ms.
    at ExecutionContext._evaluateInternal (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:217:19)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async ExecutionContext.evaluate (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:106:16)
    at async generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:208:12)
    at async toHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:87:18)
    at async Object.generate [as respec] (/u/spec-generator/generators/respec.js:13:40)
    at async /u/spec-generator/server.js:89:44

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@jongund jongund changed the title initial draft for accessible name using caption role Issue 1019: initial draft for accessible name using caption role Aug 1, 2019
@jongund jongund changed the title Issue 1019: initial draft for accessible name using caption role Issue1019 initial draft for accessible name using caption role Aug 1, 2019
@jongund
Copy link
Contributor Author

jongund commented Aug 1, 2019

Updated the pull request by restricting the use of the caption technique to first or last child element.

index.html Outdated Show resolved Hide resolved
@scottaohara
Copy link
Member

looking at this some more and the caption role definition in general, i'm curious as to why it states:

Authors SHOULD reference the element with role caption by setting aria-describedby on the figure or table.

in HTML, caption and figcaption provide accessible names for these elements, not descriptions.

@jongund
Copy link
Contributor Author

jongund commented Sep 5, 2019

Suggestion from ARIA call today to add treegrid to the list of roles and to merge legend and caption to create a single role

@jongund
Copy link
Contributor Author

jongund commented Sep 9, 2019

@scottaohara @jnurthen @mcking65

I have updated the pull request to make caption and legend synonyms, but there is one difference that may need to be addressed. Elements with the role caption should be able to provide the accessible name for elements with the role figure, from either being the first or last child element with role of caption. In the updated pull request I define caption as providing an accessible name from either being the first or last child element, and legend only from being the first child element.

@carmacleod
Copy link
Contributor

@jongund

In the updated pull request I define caption as providing an accessible name from either being the first or last child element, and legend only from being the first child element.

Actually, according to the HTML spec, table caption needs to be the first child also:

Contexts in which this element can be used:
As the first element child of a table element.

It has the same requirement as legend:

Contexts in which this element can be used:
As the first child of a fieldset element.

It's only figcaption that can be first or last:

Contexts in which this element can be used:
As the first or last child of a figure element.

So:

...there is one difference that may need to be addressed...

Agreed. If we define caption and legend roles as synonyms, then HTML caption, figcaption, and legend elements would all default to a single "caption/legend role", and this would likely lead to some strange ambiguities regarding whether or not "caption/legends" are allowed at the end of their parent elements.

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@carmacleod carmacleod linked an issue Nov 2, 2020 that may be closed by this pull request
Base automatically changed from master to main January 20, 2021 22:59
@pkra pkra added this to the ARIA 1.3 milestone Jan 12, 2022
@jnurthen
Copy link
Member

Closing as this feature is no longer intended to ship

@jnurthen jnurthen closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessible name from caption
5 participants