Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up Required Context Role: group #1359

Merged
merged 4 commits into from Dec 17, 2020

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Nov 25, 2020

The group role can only be a required context role if the group is contained in the primary context role.

So:

  • option can only be in a group if the group is in a listbox
  • treeitem can only be in a group if the group is in a tree
  • menuitem[checkbox|radio] can only be in a group if the group is in a menu or menubar

Preview (#option) (#treeitem) (#menuitem) | Diff

- only if group is contained in primary context role
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this helps clarify. thank you

@carmacleod
Copy link
Contributor Author

@mcking65
This PR doesn't conflict with #1340 at all because this PR only touches Required Context Role in the Characteristics Tables, and your PR only changes words in the prose. In fact, I think they work together to more strongly clarify how groups fit in to listboxes and trees.

This PR also touches the menuitem roles. After both PRs go in, we can look at whether the menuitem prose needs to be updated to match the new prose in listbox and tree. I'll open an issue as a reminder.

index.html Outdated Show resolved Hide resolved
Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are adding this new concept we should be complete. I think we are missing changes to required context role on
row (table -> rowgroup , grid -> rowgroup, treegrid -> rowgroup)

@carmacleod
Copy link
Contributor Author

I think we are missing changes to required context role on
row (table -> rowgroup , grid -> rowgroup, treegrid -> rowgroup)

Good catch, @jnurthen !
Agreed, and done.
I have re-requested a review from you. Thanks!

@jnurthen jnurthen added the Agenda label Dec 9, 2020
@carmacleod
Copy link
Contributor Author

This is ready for final review.

The latest commit reorders group/rowgroup items that are required context roles for option, treeitem, and menuitem roles so that the group comes first, followed by left arrow, followed by the contained item role, as suggested by @jnurthen in today's call.

This uses a left-pointing arrow character in an abbr with title="contained by", which is basically a copy of the markup with the right-pointing arrow character in an abbr with title="containing" that has been used in required owned elements since ARIA 1.0. I've opened #1368 to revisit this markup, as discussed on the call.

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

@jnurthen jnurthen merged commit c803925 into master Dec 17, 2020
@jnurthen jnurthen deleted the car/required-context-role-group branch March 3, 2021 16:57
@pkra pkra added this to the ARIA 1.3 milestone Jan 12, 2022
@pkra pkra mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small but important omission in option role spec
5 participants