Add role=image as synonym for role=img #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmacleod
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Other than fixing up that one id, looks good to me!
Thanks, @scottaohara!
|
@cookiecrook I'm guessing that you will enjoy reviewing this one. ;) |
cookiecrook
approved these changes
Dec 18, 2020
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
mcking65
requested changes
Jan 3, 2021
MelSumner
approved these changes
Jan 7, 2021
|
fixes #758 |
|
Decision in 25-Mar-2021 meeting - no fallback role |
revise the wording per matt’s feedback. Removed the paragraph on fallback per the decision the WG came to in the march 25th call.
mcking65
approved these changes
Apr 22, 2021
jnurthen
approved these changes
May 6, 2021
jnurthen
pushed a commit
that referenced
this pull request
May 6, 2021
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
12 tasks
|
created a bug with chromium to get this implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
noneas a reference point, created a first draft of theimageentry into the spec.This initial commit only adds the note about why
imageis being added to the newimageentry. Once we are happy with this note, we can add it to theimgsection as well... if we think that's necessary (they do show up right next to each other in the spec, after all).Preview (#image) (#img) | Diff