New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA: Editorial cleanup needed to "Presentational Roles Conflict Reso… #852

Merged

jnurthen merged 5 commits into master from issue646

Mar 3, 2020

Contributor

carmacleod commented Nov 30, 2018 •

edited by pr-preview bot

…lution" section #646

Please see #646 (comment) for reviewing suggestion.

Resolves #646.

carmacleod requested review from mcking65 and joanmarie

November 30, 2018 00:14

carmacleod mentioned this pull request

ARIA: Editorial cleanup needed to "Presentational Roles Conflict Resolution" section #646

Closed

jnurthen reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

jnurthen added the Agenda label

jnurthen removed the Agenda label

scottaohara reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

scottaohara requested changes

View reviewed changes

Member

scottaohara left a comment

see comment please.


          ARIA: Editorial cleanup needed to "Presentational Roles Conflict Reso…

762a85c

…lution" section #646

carmacleod requested a review from scottaohara

October 10, 2019 14:05

Contributor Author

carmacleod commented Oct 10, 2019

@joanmarie
I really need your review on this, because I had to resolve conflicts with PR #885 and I'm not 100% sure that I addressed all of your concerns. Particularly with that middle point there, about required owned elements.

Here's a preview link to the Presentational Roles Conflict Resolution section.

joanmarie reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

joanmarie reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

joanmarie reviewed

View reviewed changes

index.html Outdated Show resolved Hide resolved

joanmarie requested changes

View reviewed changes

Contributor

joanmarie left a comment

See inline comments for proposed changes.

scottaohara approved these changes

View reviewed changes

Member

scottaohara commented Oct 10, 2019

approved the changes per my comments, but +1 to @joanmarie's comments


          - remove references to accessibility API mappings

fa71c38

- remove understandable
- remove "user agent MAY resort to an internal recovery mechanism"

carmacleod force-pushed the issue646 branch from 3d21d88 to fa71c38 Compare

October 10, 2019 17:32

carmacleod requested a review from joanmarie

October 10, 2019 17:34

joanmarie approved these changes

View reviewed changes

carmacleod requested a review from jnurthen

October 10, 2019 18:33

carmacleod mentioned this pull request

What are focusable elements with role=presentation? #1041

Closed

JAWS-test mentioned this pull request

Update example 13, aria-haspopup is no longer global #1183

Closed


          Make "User agents" the subject of the MUST NOT.

14d78f8

carmacleod mentioned this pull request

What does focusable or otherwise interactive mean #1192

Open


          Remove "host language" and link "elements" to definition

27a083f

Contributor Author

carmacleod commented Feb 20, 2020

Hi, @mcking65! This PR is ready for review.

Note that the Diff is messy because I reorganized words and moved things into a bulleted list.
The Preview is definitely easier to follow.

I only changed the prose in the Presentational Roles Conflict Resolution section (nothing else), so there's only 3 paragraphs plus the example to review (the bulleted list is in paragraph 2).

Note that the phrase "or otherwise interactive" is still being discussed in #1192, so for now, I think we should just keep that phrase as-is in order to get this PR merged sooner.

Contributor

mcking65 commented Feb 27, 2020

The example helps a lot, but I am concerned about an example that goes against APG guidance. We caution against using aria-label on a heading.

carmacleod linked an issue

that may be closed by this pull request

Update example 13, aria-haspopup is no longer global #1183

Closed


          use aria-describedby on h1 instead of aria-label

855f4df

add "with its implicit role" for clarity

Contributor Author

carmacleod commented Feb 28, 2020

@mcking65 Notes for the latest commit:

changed example to use aria-describedby on the heading instead of aria-label
added "with its implicit role" in 2 places (for clarity on how UA should expose element)

Contributor Author

carmacleod commented Feb 28, 2020

@jnurthen Example is fixed up. Here's the ping you requested. :)

jnurthen approved these changes

View reviewed changes

scottaohara approved these changes

View reviewed changes

jnurthen merged commit bf28544 into master

jnurthen pushed a commit that referenced this pull request


          ARIA: Editorial cleanup needed to "Presentational Roles Conflict Reso… (

cfffbc1

#852)

* ARIA: Editorial cleanup needed to "Presentational Roles Conflict Resolution" section #646
* - remove references to accessibility API mappings
- remove understandable
- remove "user agent MAY resort to an internal recovery mechanism"
* Make "User agents" the subject of the MUST NOT.
* Remove "host language" and link "elements" to definition
* use aria-describedby on h1 instead of aria-label
add "with its implicit role" for clarity

carmacleod added a commit that referenced this pull request


          ARIA: Editorial cleanup needed to "Presentational Roles Conflict Reso… (

015d9f7

#852)

* ARIA: Editorial cleanup needed to "Presentational Roles Conflict Resolution" section #646
* - remove references to accessibility API mappings
- remove understandable
- remove "user agent MAY resort to an internal recovery mechanism"
* Make "User agents" the subject of the MUST NOT.
* Remove "host language" and link "elements" to definition
* use aria-describedby on h1 instead of aria-label
add "with its implicit role" for clarity

jnurthen deleted the issue646 branch

July 23, 2020 22:27

pkra mentioned this pull request

FPWD of ARIA 1.3 #1331

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment