Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Supporting files for prohibited roles #33

Merged
merged 4 commits into from Jun 28, 2019
Merged

Conversation

jnurthen
Copy link
Member

To support w3c/aria#985

Copy link
Member

@michael-n-cooper michael-n-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok, at least doesn't break anything obvious when I test locally. It seems it's introducing three new concepts - encapsulation, legend, prohibited, although the subject just mentioned prohibited. But presumably it's clean enough to treat them together.

This is a draft pull request, so I'll just approve for now, can merge once it's marked ready for review. Pull 985 in aria seems to have redundant changes, I assume it's cleaner to remove the changes in "common" from that pull request, as they'll come in when the common directory is updated upon merge of this pull request.

@jnurthen
Copy link
Member Author

This is a draft pull request, so I'll just approve for now, can merge once it's marked ready for review. Pull 985 in aria seems to have redundant changes, I assume it's cleaner to remove the changes in "common" from that pull request, as they'll come in when the common directory is updated upon merge of this pull request.

Yes - I'm aware of this - see w3c/aria#985 (comment)

@jnurthen jnurthen marked this pull request as ready for review June 28, 2019 19:56
@jnurthen jnurthen removed the WIP label Jun 28, 2019
@jnurthen jnurthen merged commit 6fbcee7 into master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants