Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditContext: Change "focus" to "activate" to avoid confusion with the focus in the activeElement #269

Closed
BoCupp-Microsoft opened this issue Aug 14, 2020 · 3 comments
Closed

EditContext: Change "focus" to "activate" to avoid confusion with the focus in the activeElement #269

BoCupp-Microsoft opened this issue Aug 14, 2020 · 3 comments

Comments

@BoCupp-Microsoft
Copy link
Contributor

Moving this EditContext issue into the editing repo.

From @snianu:

EditContext's focus doesn't steal the focus away from DOM. This creates confusion so consider renaming it to something else (Activate?)
@BoCupp-Microsoft BoCupp-Microsoft mentioned this issue Aug 14, 2020
Closed
@BoCupp-Microsoft BoCupp-Microsoft mentioned this issue Aug 14, 2020
Closed
@BoCupp-Microsoft
Copy link
Contributor Author

Note that we may revisit this concept since the latest thinking is that an EditContext can be associated with one or more DOM elements. With that approach it may make sense to automatically activate and deactivate the EditContext as the corresponding elements are focused or blurred.

Despite the above, I have created a pull request since at a minimum we won't want the EditContext APIs to remain named focus and blur.

@snianu
Copy link
Contributor

snianu commented Jun 14, 2021

@alexkeng FYI..

@alexkeng
Copy link
Contributor

close this issue since we have chagned to automatically activate and deactivate the editContext as the assoicated elements are focused or blurred:
2794801: EditContext: bind editContext.focus with element.focus | https://chromium-review.googlesource.com/c/chromium/src/+/2794801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename EditContext.focus/blur to activate/deactivate. BoCupp-Microsoft/editing
4 participants
@johanneswilm @BoCupp-Microsoft @alexkeng @snianu