Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should parts of Input Events level 2 be moved to level 1? #275

Closed
johanneswilm opened this issue Nov 13, 2020 · 9 comments
Closed

Should parts of Input Events level 2 be moved to level 1? #275

johanneswilm opened this issue Nov 13, 2020 · 9 comments
Labels
Agenda+ Agenda item to be inserted in the Editing TF meeting queue

Comments

@johanneswilm
Copy link
Contributor

When we created level 1 and 2 of Input Events it was because the Chromium team found it impossible to make some beforeinput events cancelable in what was then the unified Input Events spec and which is now known as level 2. Particularly any inputType that added or removed content was to not be cancelable in Chromium. So we made a level 1 that did not specify that they were cancelable and a level 2 that specified that almost all beforeinput events were cancelable.

However, now it seems like Chromium currently actually does allow a lot (all?) of those that are undefined in level 1 to be cancelable. The question is then - if both Chromium and Webkit have implemented this part of level 2 and noone has implemented just level 1, should we move this from level 2 to level 1 so that the delta between the two is smaller?

See https://jsfiddle.net/yv1sg2td/7/
See also w3c/input-events#115
@johanneswilm johanneswilm added the Agenda+ Agenda item to be inserted in the Editing TF meeting queue label Nov 13, 2020
@johanneswilm johanneswilm changed the title Should sparts of Input Events level 2 be moved to level 1? Should parts of Input Events level 2 be moved to level 1? Nov 13, 2020
@gked
Copy link

gked commented Nov 13, 2020

@alexkeng and @snianu do you know if the change was intentional? If so, +1 to @johanneswilm proposal to update the spec.

@johanneswilm
Copy link
Contributor Author

Yes, even if it was not intentional I am wondering if this will be reverted now that it has shipped like this in Chromium already? The current behavior is the same as Webkit.

@johanneswilm johanneswilm mentioned this issue Dec 7, 2020
Open
@snianu
Copy link
Contributor

snianu commented Dec 8, 2020

Adding @NavidZ @bokand as I'm not sure who implemented the input events in Chromium and if these changes were intentional.

@NavidZ
Copy link
Member

NavidZ commented Dec 8, 2020

FYI @mustaqahmed as for the current owner of the code base.

@johanneswilm
Copy link
Contributor Author

ping @mustaqahmed

@gked
Copy link

gked commented Jan 8, 2021 •
edited

Ok, I've done some digging.
This commit introduced the change: https://chromium-review.googlesource.com/c/chromium/src/+/1585167
And this is the bug that requested it: https://bugs.chromium.org/p/chromium/issues/detail?id=892360&q=892360&can=2

In the bug, there is an ask to make Chrome comply with Level 2 spec.

I would agree with @johanneswilm 's analysis and don't think this was accidental nor that it will be reverted.

I support making the change to the spec.

@mustaqahmed
Copy link
Member

I also support the change. Thanks @gked for covering my absence.

@gked
Copy link

gked commented Mar 9, 2021

@johanneswilm proposing to close this issue. Thoughts?

@johanneswilm
Copy link
Contributor Author

johanneswilm commented Mar 10, 2021 via email

@gked gked closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Agenda+ Agenda item to be inserted in the Editing TF meeting queue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@johanneswilm @mustaqahmed @gked @NavidZ @snianu