Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EditContext.focus/blur to activate/deactivate. #271

Closed
wants to merge 1 commit into from
Closed

Rename EditContext.focus/blur to activate/deactivate. #271

wants to merge 1 commit into from

Conversation

BoCupp-Microsoft
Copy link
Contributor

Closes #269

@travisleithead
Copy link
Member

Hey @alexkeng and @BoCupp-Microsoft, should this PR now be closed (without merging) given that the corresponding issue #269 that spawned this PR had a design change?

@travisleithead travisleithead added the Agenda+ Agenda item to be inserted in the Editing TF meeting queue label Aug 25, 2021
@BoCupp-Microsoft
Copy link
Contributor Author

BoCupp-Microsoft commented Aug 25, 2021 via email

@travisleithead
Copy link
Member

Closing PR per author comment.

@travisleithead travisleithead removed the Agenda+ Agenda item to be inserted in the Editing TF meeting queue label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gked gked gked approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EditContext: Change "focus" to "activate" to avoid confusion with the focus in the activeElement
3 participants
@BoCupp-Microsoft @travisleithead @gked