Remove "onoverconstrained" #576

armax00 · 2019-04-04T07:47:27Z

Fixes #573

Considering the thread in #573, it seems to me that there is a
relatively large consensus as what the faith of onoverconstrained should
be. This commit attempts to remove onoverconstrained from the
mediastream spec.

Considering the thread in #573, it seems to me that there is a relatively large consensus as what the faith of onoverconstrained should be. This commit attempts to remove onoverconstrained from the mediastream spec.

alvestrand · 2019-04-04T08:04:01Z

Always use informative titles.

getusermedia.html

guidou · 2019-04-04T15:07:25Z

The section added back talks about sources straying outside constraints, but constraints belong to tracks, not sources.
Maybe say that tracks may temporarily stray outside constraints?

armax00 · 2019-04-05T09:27:29Z

The section added back talks about sources straying outside constraints, but constraints belong to tracks, not sources.
Maybe say that tracks may temporarily stray outside constraints?

You are right with respect to where the constraints reside, but if I understand correctly the concept of source in the spec is loose and might indicate the devices, for example, that are used to record audio. In that case it would be the devices' conditions that change so that the track cannot satisfy the constraints anymore, hence to me it sounds like we do not need the change. Possibly, a way to rephrase it could be this:

"sources conditions may dynamically change such that the related tracks might not satisfy the constraints any longer"

What do you think?

guidou · 2019-04-05T09:58:26Z

Your proposal sgtm

…acks.

armax00 · 2019-04-05T11:30:00Z

Your proposal sgtm

Done, a slightly rephrased to match the existing text. PTAL.

getusermedia.html

armax00 · 2019-04-15T10:27:10Z

Please, take a look :)

armax00 · 2019-04-23T04:48:57Z

Friendly ping.

henbos

LGTM. The Travis error (getusermedia.html:194:14: Warning: inserting implicit ) looks unrelated.

alvestrand · 2019-04-25T14:50:11Z

Seems ready to merge, but let's check with @dontcallmedom for completeness before merging.

jan-ivar

Lgtm modulo stray

dontcallmedom · 2019-04-25T14:53:09Z

LGTM as well except indeed for the stray 

armax00 · 2019-04-25T19:15:19Z

Lgtm modulo stray 

What I do not understand is why that  should be spurious. There is a  open above that would otherwise never get closed. Maybe it should be placed before <ul>?

armax00 · 2019-04-26T07:42:05Z

After two tests we did with hbos, it seems that Travis has something wrong in how it is creating the checkout because is always failing with the same hash (which makes me believe it is not the specific pull request but rather something wrong from Travis' side).

henbos · 2019-04-26T08:06:07Z

Travis is broken, it's not this PR. I got it here too #580:

Unhandled rejection Error: Command failed: /usr/bin/git checkout 7b144b3b83ce296d5b29c5e4fc2ea2a65e9d3f32
fatal: reference is not a tree: 7b144b3b83ce296d5b29c5e4fc2ea2a65e9d3f32

Exact same problem

…he event. With the pull request #576 (w3c/mediacapture-main#576), the WebRTC Media Capture Stream specification does not include onoverconstrained and OverconstrainedErrorEvent. This CL's purpose is to remove WPT tests and code related to the event that are now not required any longer. BUG=956968 Change-Id: I430d1298fb944562de74d1cbf7ce05df7a5838ac

…he event. With the pull request #576 (w3c/mediacapture-main#576), the WebRTC Media Capture Stream specification does not include onoverconstrained and OverconstrainedErrorEvent. This CL's purpose is to remove WPT tests and code related to the event that are now not required any longer. BUG=956968 Change-Id: I430d1298fb944562de74d1cbf7ce05df7a5838ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584271 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#655926}

… related files and code for the event., a=testonly Automatic update from web-platform-tests [OverconstrainedErrorEvent] Remove tests related files and code for the event. With the pull request #576 (w3c/mediacapture-main#576), the WebRTC Media Capture Stream specification does not include onoverconstrained and OverconstrainedErrorEvent. This CL's purpose is to remove WPT tests and code related to the event that are now not required any longer. BUG=956968 Change-Id: I430d1298fb944562de74d1cbf7ce05df7a5838ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584271 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#655926} -- wpt-commits: 034c49216807d08b9e638c6a745386c683e780ea wpt-pr: 16560

…he event. With the pull request #576 (w3c/mediacapture-main#576), the WebRTC Media Capture Stream specification does not include onoverconstrained and OverconstrainedErrorEvent. This CL's purpose is to remove WPT tests and code related to the event that are now not required any longer. BUG=956968 Change-Id: I430d1298fb944562de74d1cbf7ce05df7a5838ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584271 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#655926}

… related files and code for the event., a=testonly Automatic update from web-platform-tests [OverconstrainedErrorEvent] Remove tests related files and code for the event. With the pull request #576 (w3c/mediacapture-main#576), the WebRTC Media Capture Stream specification does not include onoverconstrained and OverconstrainedErrorEvent. This CL's purpose is to remove WPT tests and code related to the event that are now not required any longer. BUG=956968 Change-Id: I430d1298fb944562de74d1cbf7ce05df7a5838ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584271 Reviewed-by: Harald Alvestrand <htachromium.org> Reviewed-by: Henrik Boström <hboschromium.org> Reviewed-by: Guido Urdaneta <guidouchromium.org> Commit-Queue: Armando Miraglia <armaxchromium.org> Cr-Commit-Position: refs/heads/master{#655926} -- wpt-commits: 034c49216807d08b9e638c6a745386c683e780ea wpt-pr: 16560 UltraBlame original commit: 43c18d35fac4dc79396098e187c207e07bc80f2c

w3c/mediacapture-main#576 removed the onoverconstrained member from the MediaStreamTrack interface.

w3c/mediacapture-main#576 removed the onoverconstrained member from the MediaStreamTrack interface. w3c/mediacapture-main@f1ed928

Fix for #573

79d1202

Considering the thread in #573, it seems to me that there is a relatively large consensus as what the faith of onoverconstrained should be. This commit attempts to remove onoverconstrained from the mediastream spec.

alvestrand changed the title ~~Fix for #573~~ Remove "onoverconstrained" (Fix for #573) Apr 4, 2019

alvestrand reviewed Apr 4, 2019

View reviewed changes

getusermedia.html Show resolved Hide resolved

Add back the section about dynamic changes but rephrased.

1f1ec64

Rephrase to clarify relationship between constraints, sources, and tr…

7fcb70c

…acks.

stefhak reviewed Apr 6, 2019

View reviewed changes

getusermedia.html Outdated Show resolved Hide resolved

stefhak reviewed Apr 6, 2019

View reviewed changes

getusermedia.html Outdated Show resolved Hide resolved

Address stefhak comments.

1888bdc

henbos changed the title ~~Remove "onoverconstrained" (Fix for #573)~~ Remove "onoverconstrained" Apr 25, 2019

henbos approved these changes Apr 25, 2019

View reviewed changes

jan-ivar approved these changes Apr 25, 2019

View reviewed changes

Moving the closing at the end of the paragraph.

96c2f13

henbos merged commit f1ed928 into w3c:master Apr 26, 2019

henbos mentioned this pull request Apr 26, 2019

Travis is failing git checkout with "reference is not a tree" #581

Closed

chromium-wpt-export-bot mentioned this pull request Apr 26, 2019

[OverconstrainedErrorEvent] Remove tests related files and code for the event. web-platform-tests/wpt#16560

Merged

sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Jan 26, 2020

Deprecate MediaStreamTrack: onoverconstrained

4bdb3e7

w3c/mediacapture-main#576 removed the onoverconstrained member from the MediaStreamTrack interface.

sideshowbarker mentioned this pull request Jan 26, 2020

Deprecate MediaStreamTrack: onoverconstrained mdn/browser-compat-data#5578

Merged

sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Jan 27, 2020

Deprecate MediaStreamTrack: onoverconstrained

5e2e029

w3c/mediacapture-main#576 removed the onoverconstrained member from the MediaStreamTrack interface. w3c/mediacapture-main@f1ed928

foolip mentioned this pull request Jun 3, 2021

Add/correct Chromium data for OverconstrainedErrorEvent (and related) mdn/browser-compat-data#10738

Merged

jan-ivar mentioned this pull request Feb 21, 2023

Restrict onconfigurationchange to background blur w3c/mediacapture-extensions#80

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove "onoverconstrained" #576

Remove "onoverconstrained" #576

armax00 commented Apr 4, 2019 •

edited by henbos

alvestrand commented Apr 4, 2019

guidou commented Apr 4, 2019

armax00 commented Apr 5, 2019

guidou commented Apr 5, 2019

armax00 commented Apr 5, 2019

armax00 commented Apr 15, 2019

armax00 commented Apr 23, 2019

henbos left a comment •

edited

alvestrand commented Apr 25, 2019

jan-ivar left a comment

dontcallmedom commented Apr 25, 2019

armax00 commented Apr 25, 2019 •

edited

armax00 commented Apr 26, 2019

henbos commented Apr 26, 2019

Remove "onoverconstrained" #576

Remove "onoverconstrained" #576

Conversation

armax00 commented Apr 4, 2019 • edited by henbos

alvestrand commented Apr 4, 2019

guidou commented Apr 4, 2019

armax00 commented Apr 5, 2019

guidou commented Apr 5, 2019

armax00 commented Apr 5, 2019

armax00 commented Apr 15, 2019

armax00 commented Apr 23, 2019

henbos left a comment • edited

Choose a reason for hiding this comment

alvestrand commented Apr 25, 2019

jan-ivar left a comment

Choose a reason for hiding this comment

dontcallmedom commented Apr 25, 2019

armax00 commented Apr 25, 2019 • edited

armax00 commented Apr 26, 2019

henbos commented Apr 26, 2019

armax00 commented Apr 4, 2019 •

edited by henbos

henbos left a comment •

edited

armax00 commented Apr 25, 2019 •

edited