Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature counters exist in makeCredential too #1370

Closed
agl opened this issue Feb 3, 2020 · 1 comment · Fixed by #1390
Closed

Signature counters exist in makeCredential too #1370

agl opened this issue Feb 3, 2020 · 1 comment · Fixed by #1390

Comments

@agl
Copy link
Contributor

agl commented Feb 3, 2020

The section of the spec about signature counters doesn't mention that they're provided by makeCredential as well as in assertions. The semantics of the makeCredential signature counter are missing.

For U2F authenticators, the signature counter in the makeCredential response will always be zero. At least some CTAP2 authenticators provide a non-zero counter. At least some CTAP2 authenticators increment a global signature counter when performing a makeCredential.

Step 10 of the makeCredential algorithm does say things, but it's a little at odds with reality: nearly all U2F authenticators use a global signature counter but browsers have to make an authenticatorData from a U2F registration response (which doesn't have a counter) and thus insert a value of zero, not the global value.

If we believe that other parts of the spec are correct, then the section on signature counters needs to be updated to talk about makeCredential counters.

@nadalin nadalin added this to the L2-WD-03 milestone Feb 19, 2020
@nadalin
Copy link
Contributor

nadalin commented Feb 26, 2020

@agl to create PR

agl added a commit to agl/webauthn that referenced this issue Mar 18, 2020
This section did not reflect the specified behaviour for signature
counters and did not mention that they are returned in makeCredential
responses too. See linked bug for details.

Fixes w3c#1370
equalsJeffH added a commit that referenced this issue Apr 2, 2020
* Update signature counters section.

This section did not reflect the specified behaviour for signature
counters and did not mention that they are returned in makeCredential
responses too. See linked bug for details.

Fixes #1370

* Apply suggestions from code review

Including Jeff and Emil's comments.

Co-authored-by: =JeffH <jdhodges@google.com>
Co-authored-by: Emil Lundberg <emil@emlun.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants