Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPM section is missing TPMT_PUBLIC validation steps #929

Closed
herrjemand opened this issue Jun 1, 2018 · 5 comments
Closed

TPM section is missing TPMT_PUBLIC validation steps #929

herrjemand opened this issue Jun 1, 2018 · 5 comments
Assignees
@herrjemand @akshayku
Labels
stat:pr-open type:technical
Milestone
L2-WD-03 Feature ...

Comments

@herrjemand
Copy link
Contributor

Propose adding TPM attestation validation steps for pubArea(TPMT_PUBLIC struct) as follows:

Validate that pubArea is valid:

  • Verify that nameAlg is set to to according hashing algorithm in TPM_ALG_ID
  • Verify that type is set to to according signature algorithm in TPM_ALG_ID
  • Verify that unique is set to the newly generated public key
  • If type is set to RSA, verify that parameters.exponent is set to 2048 bits for
@herrjemand
Copy link
Contributor Author

cc @akshayku

@selfissued
Copy link
Contributor

@akshayku is the proposed text above correct?

@akshayku akshayku added this to the PropRec milestone Jun 20, 2018
@akshayku
Copy link
Contributor

I am verifying all the fields but this seems like a good clarification for TPM verification steps.

@herrjemand herrjemand mentioned this issue Jun 22, 2018
Closed
@akshayku akshayku modified the milestones: PropRec, L2-WD-00 Jun 27, 2018
@emlun emlun mentioned this issue Jul 4, 2018
Closed
@nadalin nadalin modified the milestones: L2-WD-01, L2-WD-02 Mar 13, 2019
@nadalin
Copy link
Contributor

nadalin commented Jun 12, 2019

@akshayku Please update

@akshayku akshayku modified the milestones: L2-WD-02, L2-WD-03 Oct 30, 2019
@equalsJeffH
Copy link
Contributor

we closed the PR #966 -- see #966 (comment)

closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herrjemand herrjemand

@akshayku akshayku

Labels
stat:pr-open type:technical
Projects
None yet
Milestone
L2-WD-03 Feature Complete
Development

No branches or pull requests
6 participants
@equalsJeffH @emlun @herrjemand @selfissued @nadalin @akshayku