Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Authenticator Definition #1195

Merged
merged 6 commits into from May 8, 2019
Merged

Update Authenticator Definition #1195

merged 6 commits into from May 8, 2019

Conversation

nicksteele
Copy link
Contributor

@nicksteele nicksteele commented Mar 27, 2019

@emlun
Copy link
Member

emlun commented Mar 28, 2019

Is there an issue corresponding to this PR?

@nicksteele
Copy link
Contributor Author

Mostly #1175 - I wanted to draw more attention to the fact that the authenticator could be defined in either software or hardware

Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me.

index.bs Outdated Show resolved Hide resolved
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicksteele
Copy link
Contributor Author

Thanks for the edits! I think this is much more concise 👍

@nadalin nadalin added this to the L2-WD-01 milestone Apr 3, 2019
@nadalin nadalin requested review from akshayku and agl April 3, 2019 07:07
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Contributor

@agl agl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly but I prefer the current wording.

@nicksteele
Copy link
Contributor Author

The current definition doesn't mention that authenticators can be grounded in software, which I think is something important to denote. I think there is confusion currently around what an authenticator is, and this is a helpful point to make.

@equalsJeffH equalsJeffH self-requested a review April 17, 2019 17:42
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a nicely done polishing, tho I'm hesitant to lose the notion of [=user verification=].

index.bs Outdated Show resolved Hide resolved
@agl
Copy link
Contributor

agl commented Apr 17, 2019

The current definition doesn't mention that authenticators can be grounded in software

Current wording includes “or a software component of the [=client=]”.

@selfissued
Copy link
Contributor

I believe the wording that @agl quotes does the trick.

@nicksteele
Copy link
Contributor Author

It isn't only "of the [=client=]" though, it could also be a component of the client device.

s/ownership/possession/
@nicksteele
Copy link
Contributor Author

@akshayku can you approve that the changes from your comments have been added?

Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment/suggestion below. thx.

index.bs Outdated
cryptographically signing and returning, in the form of an [=Authentication Assertion=],
a challenge and other data presented by a [=[WRP]=] (in concert with the [=[WAC]=]).
:: A cryptographic entity, existing in hardware or software, that can [=registration|register=] a user with a given [=[RP]=]
and later [=Authentication Assertion|assert possession=] of the registered [=public key credential=] when requested by the [=[RP]=].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to loose the notion of user verification:
suggest:
...assert possession=] of the registered [=public key credential=], and optionally [=user verification|verifying the user=], when requested by the [=[RP]=].

@nadalin
Copy link
Contributor

nadalin commented May 2, 2019

@nicksteele Please see @equalsJeffH comments, and update so we can merge this

@nicksteele
Copy link
Contributor Author

Changes have been made and are ready for review @equalsJeffH

@equalsJeffH equalsJeffH merged commit 1b13d2e into w3c:master May 8, 2019
emlun added a commit that referenced this pull request May 9, 2019
@emlun emlun mentioned this pull request May 9, 2019
emlun added a commit that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants