Add guidance on using U2F key handles with appid extension #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not entirely happy with how the added text talks about "U2F credentials" while the preceding paragraph is about "credentials created using the legacy FIDO JavaScript APIs", but I think this could be the way to go after all. I experimented with abstracting it as "legacy credentials" or "AppID credentials", but since U2F is currently our only backwards compatibility I felt like that makes it unnecessarily vague and half defeats the purpose of adding specific guidance on how to authenticate U2F credentials. |
agl
approved these changes
Jun 5, 2019
equalsJeffH
approved these changes
Jun 11, 2019
|
I will review this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1229
Preview | Diff