Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-focus resident key definitions around allowCredentials aspect #1249

Merged
merged 7 commits into from Jul 17, 2019
Merged

Re-focus resident key definitions around allowCredentials aspect #1249

merged 7 commits into from Jul 17, 2019

Conversation

emlun
Copy link
Member

@emlun emlun commented Jul 1, 2019 •
edited by pr-preview bot

Closes #1197.

Preview | Diff

@emlun emlun added this to the L2-WD-02 milestone Jul 1, 2019
@emlun emlun self-assigned this Jul 1, 2019
agl
agl approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@agl agl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This doesn't rename things at all, but it's unclear whether we'll end up doing that even in CTAP2—“resident” might be too embedded in things now. But this clarifies the definition usefully, thanks.

equalsJeffH
equalsJeffH approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thx for doing this @emlun. Some modest polish comments included as a bonus and for your consideration :)

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@emlun emlun requested a review from equalsJeffH July 3, 2019 14:47
equalsJeffH
equalsJeffH reviewed Jul 3, 2019
View reviewed changes
index.bs Show resolved Hide resolved
equalsJeffH
equalsJeffH approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @emlun!

@emlun emlun merged commit 3ad7ad7 into master Jul 17, 2019
@emlun emlun deleted the issue-1197-rk branch July 17, 2019 19:15
WebAuthnBot pushed a commit that referenced this pull request Jul 17, 2019
Built by Travis-CI: 3ad7ad7 Merge pull request #1249 from w3c/issue-1…
c206946 
…197-rk
WebAuthnBot pushed a commit that referenced this pull request Jul 17, 2019
Built by Travis-CI: 3ad7ad7 Merge pull request #1249 from w3c/issue-1…
f60ceac 
…197-rk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@agl agl agl approved these changes

@akshayku akshayku akshayku approved these changes

Assignees

@emlun emlun

Labels
type:editorial
Projects
None yet
Milestone
L2-WD-02
Development

Successfully merging this pull request may close these issues.

Re-focus resident key descriptions on allowCredentials aspect
4 participants
@emlun @agl @equalsJeffH @akshayku