Add note about decoding U2F keyhandles. #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
U2F key handles need to be base64url decoded before being used as ArrayBuffers in WebAuthn calls. This isn't completely obvious so this change adds a clarification to the appid and appidExclude extensions.
|
thank you! |
equalsJeffH
reviewed
Aug 9, 2019
There was a problem hiding this comment.
These are just comments on @baloo's comments (github is not allowing me to make comments without it being construed as a "review"). [and then after I did a [submit review], baloo's comments (and mine) disappeared? oh well... ]
equalsJeffH
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
LGTM, good catch @agl :)
I just suggest we link to our dfn of "base64url encoding".
WebAuthnBot
pushed a commit
that referenced
this pull request
Aug 21, 2019
WebAuthnBot
pushed a commit
that referenced
this pull request
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
U2F key handles need to be base64url decoded before being used as
ArrayBuffers in WebAuthn calls. This isn't completely obvious so this
change adds a clarification to the appid and appidExclude extensions.
Preview | Diff