Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrichen registration and authentication ceremonies definitions #1330

Merged
merged 5 commits into from Jun 15, 2020
Merged

Enrichen registration and authentication ceremonies definitions #1330

merged 5 commits into from Jun 15, 2020

Conversation

emlun
Copy link
Member

@emlun emlun commented Oct 21, 2019 •
edited by pr-preview bot

Fixes #1099, although not entirely in line with the prompt:

e.g., add links to the registration and authentication ceremonies definitions pointing to:

Preview | Diff

@emlun emlun added this to the L2-WD-02 milestone Oct 21, 2019
@emlun emlun self-assigned this Oct 21, 2019
equalsJeffH
equalsJeffH suggested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks @emlun, this is a good start. Though, I don't think we ought to be pointing down into the [[#sctn-createCredential]] and [[#sctn-discover-from-external-source]] browser algs at this level of abstraction. I suggest instead pointing at WebAuthn RP Ops, and the two subsections (registration and authn) there.

Once we land PR #1300, we can perhaps add Notes to the first steps (say) of Registering a New Cred and Verifying an Authn Assn pointing back up to the new-and-improved Use Cases section with its discussion of which options settings to use to manifest which use cases.

what do you think?

@emlun
Copy link
Member Author

emlun commented Oct 22, 2019

Hey, thanks @emlun, this is a good start. Though, I don't think we ought to be pointing down into the [[#sctn-createCredential]] and [[#sctn-discover-from-external-source]] browser algs at this level of abstraction. I suggest instead pointing at WebAuthn RP Ops, and the two subsections (registration and authn) there.

Good points, thanks!

Once we land PR #1300, we can perhaps add Notes to the first steps (say) of Registering a New Cred and Verifying an Authn Assn pointing back up to the new-and-improved Use Cases section with its discussion of which options settings to use to manifest which use cases.

Sounds good! Let's put this one on hold for now, then.

@emlun emlun added stat:Blocked Prerequisites are not yet satisfied stat:puntable Issue or PR that is candidate to move to a later milestone labels Oct 22, 2019
@nadalin nadalin modified the milestones: L2-WD-02, L2-WD-03 Oct 30, 2019
@equalsJeffH equalsJeffH mentioned this pull request Nov 6, 2019
Closed
@emlun emlun removed the stat:puntable Issue or PR that is candidate to move to a later milestone label Nov 6, 2019
@emlun emlun removed the stat:Blocked Prerequisites are not yet satisfied label Jun 3, 2020
@emlun
Copy link
Member Author

emlun commented Jun 5, 2020

@equalsJeffH Since #1300 was scrapped, do we also scrap your second paragraph? First paragraph is fixed now.

@equalsJeffH equalsJeffH self-requested a review June 10, 2020 19:25
equalsJeffH
equalsJeffH approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @emlun!

@equalsJeffH equalsJeffH merged commit 0df170f into master Jun 15, 2020
WebAuthnBot pushed a commit that referenced this pull request Jun 15, 2020
Built by Travis-CI: 0df170f Enrichen registration and authentication …
fcd41d6 
…ceremonies definitions (#1330)
WebAuthnBot pushed a commit that referenced this pull request Jun 15, 2020
Built by Travis-CI: 0df170f Enrichen registration and authentication …
d466f8b 
…ceremonies definitions (#1330)
@emlun emlun deleted the issue-1099-enrichen-ceremony-defs branch June 22, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equalsJeffH equalsJeffH equalsJeffH approved these changes

Assignees

@emlun emlun

Labels
type:editorial
Projects
None yet
Milestone
L2-WD-03 Feature Complete
Development

Successfully merging this pull request may close these issues.

enrichen registration and authentication ceremonies definitions
3 participants
@emlun @equalsJeffH @nadalin