Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clearer recommendation on what to do with transport hints #1369

Merged
merged 3 commits into from Mar 11, 2020
Merged

Add clearer recommendation on what to do with transport hints #1369

merged 3 commits into from Mar 11, 2020

Conversation

emlun
Copy link
Member

@emlun emlun commented Jan 30, 2020 •
edited by pr-preview bot

Fixes #1368.

With this we have

Should we add hooks anywhere else too?

Preview | Diff

@emlun emlun added this to the L2-WD-03 milestone Jan 30, 2020
@emlun emlun requested review from agl and equalsJeffH January 30, 2020 11:23
@emlun emlun self-assigned this Jan 30, 2020
equalsJeffH
equalsJeffH approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @emlun! wrt where else to note this, perhaps add a Note to the description of the transports member of the PublicKeyCredentialDescriptor, mentioning that RPs ought to "store" and "retrieve" the hints and linking to the RP operations sections?

equalsJeffH
equalsJeffH approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx :) one v. minor comment.

index.bs Outdated Show resolved Hide resolved
@arshadnoor
Copy link

You might want to consider adding a note that not all RPs will have to deal with this - only those who choose to create their own FIDO2 Servers. Third-party commercial and open-source FIDO2 Servers are more than likely capable of handling the transport hints, thus allowing RPs to focus on their business application rather than protocol semantics.

@emlun
Copy link
Member Author

emlun commented Mar 10, 2020

Thanks, but I don't think such a distinction is necessary to have in the spec. The party making the JavaScript calls is the one that will need to call getTransports() and know what to do with the result, even if what they need to do is offload it to a separate third-party server.

@emlun emlun merged commit ae29ff0 into master Mar 11, 2020
@emlun emlun deleted the issue-1368-transports-instructions branch March 11, 2020 19:09
WebAuthnBot pushed a commit that referenced this pull request Mar 11, 2020
Built by Travis-CI: ae29ff0 Merge pull request #1369 from w3c/issue-1…
c205120 
…368-transports-instructions
WebAuthnBot pushed a commit that referenced this pull request Mar 11, 2020
Built by Travis-CI: ae29ff0 Merge pull request #1369 from w3c/issue-1…
267596b 
…368-transports-instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agl agl agl approved these changes

@equalsJeffH equalsJeffH equalsJeffH approved these changes

Assignees

@emlun emlun

Labels
subtype:rp-ops type:editorial
Projects
None yet
Milestone
L2-WD-03 Feature Complete
Development

Successfully merging this pull request may close these issues.

Clarity on transport hints
4 participants
@emlun @arshadnoor @agl @equalsJeffH