Update signature counters section. #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section did not reflect the specified behaviour for signature counters and did not mention that they are returned in makeCredential responses too. See linked bug for details. Fixes w3c#1370
equalsJeffH
approved these changes
Mar 25, 2020
akshayku
approved these changes
Mar 25, 2020
|
(Good to merge once I take care of suggested change.) |
emlun
approved these changes
Apr 1, 2020
Including Jeff and Emil's comments.t Co-Authored-By: =JeffH <jdhodges@google.com> Co-Authored-By: Emil Lundberg <emil@emlun.se>
WebAuthnBot
pushed a commit
that referenced
this pull request
Apr 2, 2020
WebAuthnBot
pushed a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section did not reflect the specified behaviour for signature
counters and did not mention that they are returned in makeCredential
responses too. See linked bug for details.
Fixes #1370
Preview | Diff