use '(client-side) discoverable credential' terminology #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..rather than the 'resident credential' and 'resident key' terms. Also changed 'non-resident credential' to 'server-side credential', along with other related fixups. Marked the latter terms as DEPRECATED.
agl
approved these changes
Apr 2, 2020
akshayku
approved these changes
Apr 8, 2020
emlun
reviewed
Apr 8, 2020
Co-Authored-By: Emil Lundberg <emil@yubico.com>
Co-Authored-By: Emil Lundberg <emil@yubico.com>
Co-Authored-By: Emil Lundberg <emil@yubico.com>
thx emlun! Co-Authored-By: Emil Lundberg <emil@yubico.com>
ve7jtb
reviewed
Apr 25, 2020
emlun
approved these changes
Apr 27, 2020
Co-Authored-By: Emil Lundberg <emil@yubico.com> Co-Authored-By: John Bradley <ve7jtb@ve7jtb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..rather than the 'resident credential' and 'resident key' terms. Also changed 'non-resident credential' to 'server-side credential', along with other related fixups. Marked the former terms as DEPRECATED.
fixes #1379 (may only "improve" it due to not addressing the notion of "forbidden to create a client-side cred", though the latter perhaps ought to be in its own issue separate from #1379)
Preview | Diff