Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEVC registration #499

Merged
merged 3 commits into from Aug 8, 2022
Merged

Add HEVC registration #499

merged 3 commits into from Aug 8, 2022

Conversation

sandersdan
Copy link
Contributor

No description provided.

@sandersdan sandersdan requested review from aboba and padenot June 16, 2022 18:49
{{EncodedVideoChunkType/key}}, and the bitstream is in
{{HevcBitstreamFormat/hevc}} format, then the {{EncodedVideoChunk}} is expected
to contain a base layer primary coded picture that is an instantaneous decoding
refresh (IDR), clean random access (CRA), or broken link access (BLA) picture.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this to match the definition of "sync sample" in the ISO BMFF embedding, but I'm not familiar enough with decoder implementations to say for sure if that's the best definition.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not familiar enough. Maybe Gary could weigh here.

@chrisn
Copy link
Member

chrisn commented Jun 29, 2022

Please let me know when this is ready, and I can run a call for consensus in the Media Working Group.

@aboba
Copy link
Collaborator

aboba commented Jun 29, 2022

@chrisn May I suggest asking Gary Sullivan to review this registration as well?

@aboba aboba mentioned this pull request Jun 29, 2022
@chcunningham
Copy link
Collaborator

Please let me know when this is ready, and I can run a call for consensus in the Media Working Group.

Please go ahead and run the CFC.

@chrisn
Copy link
Member

chrisn commented Jun 29, 2022

The call for consensus is here: https://lists.w3.org/Archives/Public/public-media-wg/2022Jun/0006.html

Co-authored-by: Chris Needham <chrisn@users.noreply.github.com>
@zeruniverse
Copy link

I saw CfC closed with no objection. Will it gets merged? https://lists.w3.org/Archives/Public/public-media-wg/2022Jul/0008.html

@chcunningham
Copy link
Collaborator

Yes, plan is to merge. I'm taking a closer look at the PR now.

@chrisn
Copy link
Member

chrisn commented Aug 8, 2022

I think the only outstanding thing is to seek review as @aboba suggested in #499 (comment). That may not need to hold up merging though.

Copy link
Collaborator

@chcunningham chcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only found one minor editorial issue. Dan is OOO, so I'll go ahead and merge this and fix the editorial glitch in a follow up commit.

hevc_codec_registration.src.html Show resolved Hide resolved
{{EncodedVideoChunkType/key}}, and the bitstream is in
{{HevcBitstreamFormat/hevc}} format, then the {{EncodedVideoChunk}} is expected
to contain a base layer primary coded picture that is an instantaneous decoding
refresh (IDR), clean random access (CRA), or broken link access (BLA) picture.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not familiar enough. Maybe Gary could weigh here.

hevc_codec_registration.src.html Show resolved Hide resolved
@chcunningham chcunningham merged commit bc711f2 into w3c:main Aug 8, 2022
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Aug 8, 2022
SHA: bc711f2
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants