New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HEVC registration #499
Conversation
{{EncodedVideoChunkType/key}}, and the bitstream is in | ||
{{HevcBitstreamFormat/hevc}} format, then the {{EncodedVideoChunk}} is expected | ||
to contain a base layer primary coded picture that is an instantaneous decoding | ||
refresh (IDR), clean random access (CRA), or broken link access (BLA) picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote this to match the definition of "sync sample" in the ISO BMFF embedding, but I'm not familiar enough with decoder implementations to say for sure if that's the best definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not familiar enough. Maybe Gary could weigh here.
Please let me know when this is ready, and I can run a call for consensus in the Media Working Group. |
@chrisn May I suggest asking Gary Sullivan to review this registration as well? |
Please go ahead and run the CFC. |
The call for consensus is here: https://lists.w3.org/Archives/Public/public-media-wg/2022Jun/0006.html |
Co-authored-by: Chris Needham <chrisn@users.noreply.github.com>
I saw CfC closed with no objection. Will it gets merged? https://lists.w3.org/Archives/Public/public-media-wg/2022Jul/0008.html |
Yes, plan is to merge. I'm taking a closer look at the PR now. |
I think the only outstanding thing is to seek review as @aboba suggested in #499 (comment). That may not need to hold up merging though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I only found one minor editorial issue. Dan is OOO, so I'll go ahead and merge this and fix the editorial glitch in a follow up commit.
{{EncodedVideoChunkType/key}}, and the bitstream is in | ||
{{HevcBitstreamFormat/hevc}} format, then the {{EncodedVideoChunk}} is expected | ||
to contain a base layer primary coded picture that is an instantaneous decoding | ||
refresh (IDR), clean random access (CRA), or broken link access (BLA) picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not familiar enough. Maybe Gary could weigh here.
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: bc711f2 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.