Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CreateEncodedStream variant API #64

Merged
merged 1 commit into from Apr 29, 2021
Merged

Remove CreateEncodedStream variant API #64

merged 1 commit into from Apr 29, 2021

Conversation

youennf
Copy link
Collaborator

@youennf youennf commented Mar 3, 2021 •
edited by pr-preview bot

@youennf
Copy link
Collaborator Author

youennf commented Mar 3, 2021

Not ready until #62 gets landed

@youennf youennf added the WIP label Mar 3, 2021
@youennf youennf mentioned this pull request Mar 4, 2021
Merged
@alvestrand alvestrand changed the title Remove script transform variant API Remove CreateEncodedStream variant API Mar 19, 2021
@alvestrand alvestrand mentioned this pull request Mar 19, 2021
Open
@youennf youennf removed the WIP label Apr 15, 2021
@alvestrand
Copy link
Contributor

I do not want to merge this until we have consensus on #18 - the issue is the cases where people actually want main-thread processing.

@youennf
Copy link
Collaborator Author

youennf commented Apr 27, 2021

Consensus to go on with this PR was reached at today WebRTC WG interim.

@guidou
Copy link
Collaborator

guidou commented Apr 28, 2021

What if instead of removing we move it to a "legacy" section, similar to the legacy section in mediacapture-main for the old version of getUserMedia?

@youennf
Copy link
Collaborator Author

youennf commented Apr 29, 2021

A legacy section would entail having precise algorithms for the old API on top of the new API. I do not think we want to go there.
I would be more inclined to do like webrtc-stats which has an Obsolete section with the old API WebIDL, no algorithm. Potentially with guidelines on how to transition to the new API.

@guidou
Copy link
Collaborator

guidou commented Apr 29, 2021

A legacy section would entail having precise algorithms for the old API on top of the new API. I do not think we want to go there.
I would be more inclined to do like webrtc-stats which has an Obsolete section with the old API WebIDL, no algorithm. Potentially with guidelines on how to transition to the new API.

I think that would work well.

@alvestrand
Copy link
Contributor

Legacy documentation is filed as issue #105.

@youennf youennf merged commit f616461 into w3c:main Apr 29, 2021
github-actions bot added a commit that referenced this pull request Apr 29, 2021
@youennf @github-actions
Remove script transform variant API (#64)
fa18bfa 
SHA: f616461
Reason: push, by @youennf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@foolip
Copy link
Member

foolip commented May 8, 2021

@alvestrand is there a Chromium bug to remove the createEncodedStreams() methods? They have already shipped in Chrome, so I was surprised when I saw this removed in w3c/webref@f8d3132.

foolip added a commit to foolip/mdn-bcd-collector that referenced this pull request May 8, 2021
@foolip
Add custom IDL for createEncodedStreams() methods
f5215ae 
See w3c/webrtc-encoded-transform#64.
@foolip foolip mentioned this pull request May 8, 2021
Merged
foolip added a commit to foolip/mdn-bcd-collector that referenced this pull request May 8, 2021
@foolip
Add custom IDL for createEncodedStreams() methods (#1147)
9788a2f 
See w3c/webrtc-encoded-transform#64.
alvestrand added a commit that referenced this pull request Jul 8, 2021
@alvestrand
Document legacy API that was removed in #64
23340a6 
Fixes #105
@fippo fippo mentioned this pull request Jul 27, 2022
Closed
@jan-ivar jan-ivar mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand alvestrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@youennf @alvestrand @guidou @foolip