Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

header extension API: do we need enabled in setParameters? #112

Closed
fippo opened this issue Aug 23, 2022 · 3 comments · Fixed by #116
Closed

header extension API: do we need enabled in setParameters? #112

fippo opened this issue Aug 23, 2022 · 3 comments · Fixed by #116
Assignees
@fippo
Labels
TPAC 2023 For discussion at TPAC

Comments

@fippo
Copy link
Contributor

fippo commented Aug 23, 2022

it seems that the enabled property
https://w3c.github.io/webrtc-extensions/#attributes-0
in setParameters is not implemented.

I think it is a headache to allow doing this for things like urn:3gpp:video-orientation which have implications for the whole pipeline.
Disabling an extension via (local) renegotiation solves the same problem, do we need this one?
@alvestrand
Copy link
Collaborator

On the principle of "let's not add complexity until we're sure we need it", I support removing this part from the spec.

@lgrahl
Copy link

lgrahl commented Aug 23, 2022 •
edited

Assuming it can be set via setOfferedRtpHeaderExtensions (the term offer here confuses me a bit) for negotiation, right? If so 👍 for getting rid of complexity. 🙂

@fippo
Copy link
Contributor Author

fippo commented Aug 23, 2022

setOfferedRtpHeaderExtensions operates before offer (and I think answer but it seems we need another test for that), active in setParameters is dynamic "within the envelope of the negotiated sdp" (a term that I would prefer to avoid :-))

@aboba aboba added the TPAC 2023 For discussion at TPAC label Aug 25, 2022
fippo added a commit to fippo/webrtc-extensions that referenced this issue Sep 27, 2022
@fippo
header extension API: remove setParameters support
87bacfc 
remove ability to dynamically turn off sending of header extensions
via setParameters. This can also be achieved with local renegotiation.

Fixes w3c#112
@fippo fippo mentioned this issue Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fippo fippo

Labels
TPAC 2023 For discussion at TPAC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

header extension API: remove setParameters support fippo/webrtc-extensions
4 participants
@fippo @alvestrand @aboba @lgrahl