Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addTransceiver does not check for uniqueness of rid #2733

Closed
docfaraday opened this issue May 11, 2022 · 2 comments · Fixed by #2775
Closed

addTransceiver does not check for uniqueness of rid #2733

docfaraday opened this issue May 11, 2022 · 2 comments · Fixed by #2775
Assignees
@docfaraday
Labels
TPAC 2022 For discussion at TPAC

Comments

@docfaraday
Copy link
Contributor

When passing more than one sendEncoding to addTransceiver, there is nothing in the spec about verifying that the rid properties are unique. This is necessary, in my opinion.
@aboba aboba assigned aboba and docfaraday and unassigned aboba Jul 19, 2022
@aboba aboba added the TPAC 2022 For discussion at TPAC label Aug 25, 2022
@jan-ivar
Copy link
Member

jan-ivar commented Sep 8, 2022

I've tested this and all browsers allow it. I agree it would be better if it threw.

const transceiver = pc.addTransceiver("video", {sendEncodings: [{rid: "hi"}, {rid: "hi"}]});

For symmetry how is a remote offer with a=simulcast:recv hi;hi treated?

@docfaraday
Copy link
Contributor Author

docfaraday commented Sep 8, 2022 •
edited

RFC 8853 does not seem to prohibit duplicate rids in the simulcast attribute, although generating a simulcast attribute with duplicates would definitely be silly. I guess the appropriate thing to do is to ignore duplicates?

@jan-ivar jan-ivar mentioned this issue Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@docfaraday docfaraday

Labels
TPAC 2022 For discussion at TPAC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TypeError on duplicate rids jan-ivar/webrtc-pc
3 participants
@aboba @docfaraday @jan-ivar