Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addTransceiver does not check for missing rid properties #2734

Closed
docfaraday opened this issue May 11, 2022 · 1 comment · Fixed by #2774
Closed

addTransceiver does not check for missing rid properties #2734

docfaraday opened this issue May 11, 2022 · 1 comment · Fixed by #2774
Assignees
@docfaraday
Labels
TPAC 2022 For discussion at TPAC

Comments

@docfaraday
Copy link
Contributor

Spec has validation steps for rid properties that are present in sendEncodings, but does not have any validation steps related to encodings without a rid property. We want to allow rid to be absent when there is only one encoding, but if there is more than one encoding we need to throw (TypeError probably) if any of those encodings are missing a rid.
@aboba aboba added the TPAC 2022 For discussion at TPAC label Aug 25, 2022
@jan-ivar jan-ivar mentioned this issue Sep 26, 2022
Merged
@jan-ivar
Copy link
Member

RESOLUTION: +1 +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@docfaraday docfaraday

Labels
TPAC 2022 For discussion at TPAC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TypeError unless all or none of encodings have rids jan-ivar/webrtc-pc
3 participants
@aboba @docfaraday @jan-ivar