Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document defaultIceServers as source of fingerprinting #643

Merged
merged 2 commits into from May 23, 2016
Merged

Document defaultIceServers as source of fingerprinting #643

merged 2 commits into from May 23, 2016

Conversation

dontcallmedom
Copy link
Member

close #627

@stefhak
Copy link
Contributor

stefhak commented May 19, 2016

LGTM

alvestrand
alvestrand reviewed May 19, 2016
View reviewed changes
webrtc.html
@@ -1156,6 +1156,12 @@
might be configured to use local or private STUN or TURN
servers. This method allows an application to learn about these
servers and optionally use them.</p>
<p class="fingerprint">This list is likely to persisent and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English: This list is likely to persistent -> This list is likely to be persistent

@alvestrand
Copy link
Contributor

@dontcallmedom please fix the grammar error and merge.

@dontcallmedom dontcallmedom merged commit cb99ae5 into master May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

defaultIceServers adds to the fingerprinting surface
3 participants
@dontcallmedom @stefhak @alvestrand