Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICE Transport State Diagram #668

Closed
wants to merge 1 commit into from
Closed

ICE Transport State Diagram #668

wants to merge 1 commit into from

Conversation

aboba
Copy link
Contributor

@aboba aboba commented May 24, 2016

Ice Transport State Diagram.

Related to Issue #457

Ice Transport State Diagram. 

Related to Issue #457
@aboba
Copy link
Contributor Author

aboba commented May 26, 2016

@taylor-b Can you review?

@taylor-b
Copy link
Contributor

taylor-b commented Jun 9, 2016

Sorry for the delay in reviewing. Here are the only issues I noticed:

  1. There shouldn't be a transition from failed to checking. Aside from an ICE restart, there's no way to get out of failed; failed means the transport has finished checking and there are no more ICE candidates on the way.
  2. For the same reason as above, there shouldn't be a transition from completed to connected.
  3. Technically it's possible to go directly from checking to completed, if there's only one candidate pair. Though since the diagram is non-normative, it's probably ok to leave this out if it makes the diagram cleaner.

Also, just to confirm: I assume that the reason there are transitions from completed->failed and connected->checking without passing through disconnected is that the current candidate pair may suddenly become unusable, from something other than consent expiring. In which case there would be no time for "liveness checks to fail". Is that correct?

@aboba
Copy link
Contributor Author

aboba commented Jun 10, 2016

@taylor-b An authenticated STUN response with error code Forbidden (403) indicates that consent has been revoked. That could cause transitions from completed to failed or from connected to checking without first going through disconnected (due to failure of "liveness checks" prior to a consent failure).

@aboba
Copy link
Contributor Author

aboba commented Jun 10, 2016

Is this closer to being right?

webrtc-icetransport-transitions

@taylor-b
Copy link
Contributor

Looks perfect to me now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants