Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A merge guide for updating webrtc-pc #2637

Merged
merged 3 commits into from May 19, 2021
Merged

A merge guide for updating webrtc-pc #2637

merged 3 commits into from May 19, 2021

Conversation

alvestrand
Copy link
Contributor

Proposal. Sketchy.

Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, with possibly some clarification needed on webrtc-extensions vs extension specs

@alvestrand
Copy link
Contributor Author

@dontcallmedom is there a preferred format / template for this sort of document?

@dontcallmedom
Copy link
Member

I realize there is an aspect this document doesn't cover: where issues should be filed between -pc and -extensions.

In terms of format, I don't think there is any particular template to follow; maybe we could put this into the README.md instead of a separate file (and if not, the README should prominently link to it).

@alvestrand
Copy link
Contributor Author

I added text to the README.md pointing here, and text to this document talking about where to file issues. Does it look ready now?

Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvestrand alvestrand merged commit 4b5007c into main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants