Skip to content
  1. Mar 27, 2024
  2. Mar 26, 2024
  3. Mar 25, 2024
  4. Mar 23, 2024
  5. Mar 22, 2024
  6. Mar 21, 2024
    • Andrei Borzenkov's avatar
      Fix TH handling in `pat_to_type_pat` function (#24571) · 6fafc51e
      Andrei Borzenkov authored and Marge Bot's avatar Marge Bot committed
      There was missing case for `SplicePat` in `pat_to_type_at` function,
      hence patterns with splicing that checked against `forall->` doesn't work
      properly because they fall into the "illegal pattern" case.
      
      Code example that is now accepted:
      
        g :: forall a -> ()
        g $([p| a |]) = ()
      6fafc51e
    • Preetham Gujjula's avatar
      docs: Remove mention of non-existent Ord instance for Complex · 247fc0fa
      Preetham Gujjula authored and Marge Bot's avatar Marge Bot committed
      The documentation for Data.Complex says that the Ord instance for Complex Float
      is deficient, but there is no Ord instance for Complex a. The Eq instance for
      Complex Float is similarly deficient, so we use that as an example instead.
      247fc0fa
    • Vladislav Zavialov's avatar
      Type operators in promoteOccName (#24570) · da2a10ce
      Vladislav Zavialov authored and Marge Bot's avatar Marge Bot committed
      Type operators differ from term operators in that they are lexically
      classified as (type) constructors, not as (type) variables.
      
      Prior to this change, promoteOccName did not account for this
      difference, causing a scoping issue that affected RequiredTypeArguments.
      
        type (!@#) = Bool
        f = idee (!@#)      -- Not in scope: ‘!@#’  (BUG)
      
      Now we have a special case in promoteOccName to account for this.
      da2a10ce
    • Alan Zimmerman's avatar
      EPA: Clean up Exactprint helper functions a bit · 5f275176
      Alan Zimmerman authored and Marge Bot's avatar Marge Bot committed
      - Introduce a helper lens to compose on `EpAnn a` vs `a` versions
      - Rename some prime versions of functions back to non-prime
        They were renamed during the rework
      5f275176
  7. Mar 20, 2024
  8. Mar 19, 2024
    • Bryan R's avatar
      testsuite: Disable T21336a on wasm · 5ff88389
      Bryan R authored and Marge Bot's avatar Marge Bot committed
      5ff88389
    • Ben Gamari's avatar
      mk/relpath: Fix quoting · cf55a54b
      Ben Gamari authored and Marge Bot's avatar Marge Bot committed
      Previously there were two instances in this script which lacked proper
      quoting. This resulted in `relpath` invocations in the binary
      distribution Makefile producing incorrect results on Windows, leading to
      confusing failures from `sed` and the production of empty package
      registrations.
      
      Fixes #24538.
      cf55a54b
    • Krzysztof Gogolewski's avatar
      Minor misc cleanups · 594bee0b
      Krzysztof Gogolewski authored and Marge Bot's avatar Marge Bot committed
      - GHC.HsToCore.Foreign.JavaScript: remove dropRuntimeRepArgs;
        boxed tuples don't take RuntimeRep args
      - GHC.HsToCore.Foreign.Call: avoid partial pattern matching
      - GHC.Stg.Unarise: strengthen the assertion; we can assert that
        non-rubbish literals are unary rather than just non-void
      - GHC.Tc.Gen.HsType: make sure the fsLit "literal" rule fires
      - users_guide/using-warnings.rst: remove -Wforall-identifier,
        now deprecated and does nothing
      - users_guide/using.rst: fix formatting
      - andy_cherry/test.T: remove expect_broken_for(23272...), 23272 is fixed
      
      The rest are simple cleanups.
      594bee0b
    • Hannes Siebenhandl's avatar
      Eliminate thunk in 'IfaceTyCon' · 349ea330
      Hannes Siebenhandl authored and Marge Bot's avatar Marge Bot committed
      Heap analysis showed that `IfaceTyCon` retains a thunk to
      `IfaceTyConInfo`, defeating the sharing of the most common instances of
      `IfaceTyConInfo`.
      We make sure the indirection is removed by adding bang patterns to
      `IfaceTyCon`.
      
      Experimental results on the agda code base, where the `mi_extra_decls`
      were read from disk:
      
      Before this change, we observe around 8654045 instances of:
      
      `IfaceTyCon[Name,THUNK_1_0]`
      
      But these thunks almost exclusively point to a shared value!
      
      Forcing the thunk a little bit more, leads to `ghc-debug` reporting:
      
      `IfaceTyCon[Name:Name,IfaceTyConInfo]`
      
      and a noticeable reduction of live bytes (on agda ~10%).
      349ea330
    • Matthew Craven's avatar
      CorePrep: Rework lowering of BigNat# literals · b56d2761
      Matthew Craven authored and Marge Bot's avatar Marge Bot committed
      Don't use bigNatFromWord#, because that's terrible:
       * We shouldn't have to traverse a linked list at run-time
         to build a BigNat# literal. That's just silly!
       * The static List object we have to create is much larger
         than the actual BigNat#'s contents, bloating code size.
       * We have to read the corresponding interface file,
         which causes un-tracked implicit dependencies. (#23942)
      
      Instead, encode them into the appropriate platform-dependent
      sequence of bytes, and generate code that copies these bytes
      at run-time from an Addr# literal into a new ByteArray#.
      A ByteArray# literal would be the correct thing to generate,
      but these are not yet supported; see also #17747.
      
      Somewhat surprisingly, this change results in a slight
      reduction in compiler allocations, averaging around 0.5%
      on ghc's compiler performance tests, including when compiling
      programs that contain no bignum literals to begin with.
      The specific cause of this has not been investigated.
      
      Since this lowering no longer reads the interface file for
      GHC.Num.BigNat, the reasoning in Note [Depend on GHC.Num.Integer]
      is obsoleted.  But the story of un-tracked built-in dependencies
      remains complex, and Note [Tracking dependencies on primitives]
      now exists to explain this complexity.
      
      Additionally, many empty imports have been modified to refer to
      this new note and comply with its guidance.  Several empty imports
      necessary for other reasons have also been given brief explanations.
      
      Metric Decrease:
          MultiLayerModulesTH_OneShot
      b56d2761
    • Matthew Craven's avatar
      Remove unused ghc-internal module "GHC.Internal.Constants" · da0d8ba5
      Matthew Craven authored and Marge Bot's avatar Marge Bot committed
      da0d8ba5
    • Matthew Pickering's avatar
      hadrian: Remove stage1 testsuite wrappers logic · 4c8f1794
      Matthew Pickering authored and Marge Bot's avatar Marge Bot committed
      Now instead of producing wrappers which pass the global package database
      argument to ghc and ghc-pkg, we write the location of the correct
      package database into the settings file so you can just use the intree
      compiler directly.
      4c8f1794